This comment is long-winded, it boils down to a few things:

1. use the existing learningResourceQueries.search query
   • After this, I expect you could remove the whole api/hooks/video_shorts directory
2. I think we should add sortby: "new"
   • The default search is pretty similar when there's no q filter (search query text), but IMO best to explicitly use new, that's closest to old -published_at, I think.

Rather than adding a new hook useVideoShortsLearningResources, I'd suggest re-using the existing learningResourceQueries.search query. Something like below.

Also:

• filter on resource_type at the API level rather than afterwards. (It probably doesn't matter much since you were filtering on "Video Short" category anyway)
  • Generally filtering serverside is better...if you request 50 results and filter client-side, you might end up with fewer. But, as I said, it shouldn't matter here. Still good to do.

I'd suggest using

  const { data, isLoading } = useQuery({
    ...learningResourceQueries.search({
      resource_category: ["Video Short"],
      resource_type: [ResourceTypeEnum.Video],
      limit: 50,
      sortBy: "new"
    }),
    select: (data) =>
      data?.result.results.filter(
        (r) => r.resource_type === ResourceTypeEnum.Video,
      ),
  })

Two notes about the select i suggested:

1. This query returns { results, time } after Search response time indicator for admin users #3186 ... it's the only query that does this, for the reasons mentioned in that pr.
2. The filter inside select is redundant. I kept it just to make TS happy.

Also

• generally nowadays we prefer useQuery(queryOptions) rather than defining custom query hooks.
• In older versions of @tanstack/react-query, defining custom query hooks was the best way, but the queryOptions helper they added in v5 eliminated the need for custom query hooks. (Custom mutation hooks still big helpful.)

Thanks! I followed the pattern from the existing useVideoShortsList hook when writing useVideoShortsLearningResources, but I can see now that using useQuery(queryOptions) is the cleaner approach. I'll keep that in mind going forward.